samples(storage): Add region tags in fastbyte samples#15403
Open
v-pratap wants to merge 1 commit intogoogleapis:mainfrom
Open
samples(storage): Add region tags in fastbyte samples#15403v-pratap wants to merge 1 commit intogoogleapis:mainfrom
v-pratap wants to merge 1 commit intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
api: storage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15403 +/- ##
==========================================
- Coverage 93.03% 93.03% -0.01%
==========================================
Files 2403 2403
Lines 219441 219441
==========================================
- Hits 204148 204147 -1
- Misses 15293 15294 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pulkit0110
requested changes
Aug 26, 2025
| co_return (co_await std::move(c1)) + (co_await std::move(c2)); | ||
| }; | ||
| //! [open-object-multiple-ranged-read] | ||
| // [END storage_read_appendable_object_mulitple_ranges] |
Member
There was a problem hiding this comment.
typo: use multiple in region tag
Pulkit0110
reviewed
Aug 26, 2025
Member
Pulkit0110
left a comment
Pulkit0110
left a comment
There was a problem hiding this comment.
I think the PR title should be samples(storage) or chore(storage)
shubham-up-47
approved these changes
Sep 22, 2025
bajajneha27
changed the title
Contributor
|
Please make sure to merge it with conventional commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added region tags for fastbyte samples
This change is